search

robotology / icub-models

Official URDF and SDF models of the iCub humanoid robot.
Creative Commons Attribution Share Alike 4.0 International
33 stars 34 forks source link

Adding manually `iCubGazeboV3_visuomanip` model #170

Closed mebbaid closed 2 years ago

mebbaid commented 2 years ago

This draft PR will track the addition of an iCub3 model with hands and eyes. Since the urdf editing was done manually and not auto-generated from CAD, i thought this PR will not follow the "usual" way of contributing to icub-models through the use of icub-models-generator. Feel free to let me know if that is not the case.

mebbaid commented 2 years ago

This PR is now ready for review.

traversaro commented 2 years ago

This PR is now ready for review.

Sorry, I missed this.

traversaro commented 2 years ago

@mebbaid Thanks, I added some comments. Can you please report the commit of icub-models from which you took the model iCubGazeboV3 that you used to build the iCubGazeboV3_visuomanip.

mebbaid commented 2 years ago

@mebbaid Thanks, I added some comments. Can you please report the commit of icub-models from which you took the model iCubGazeboV3 that you used to build the iCubGazeboV3_visuomanip.

Thanks @traversaro , i will go through the comments. Meanwhile, the commit of icub-models is b32320e547aeb0ce3346c6ee88e5ee52eb4bbfc7

traversaro commented 2 years ago

Thanks @mebbaid, can I squash the commits during the merge?

mebbaid commented 2 years ago

Thanks @mebbaid, can I squash the commits during the merge?

Certo @traversaro!

traversaro commented 2 years ago

Thanks @mebbaid !