search

robotology / icub-models

Official URDF and SDF models of the iCub humanoid robot.
Creative Commons Attribution Share Alike 4.0 International
33 stars 34 forks source link

Fix minor issues in `iCubGazeboV3_visuomanip` #176

Closed mebbaid closed 1 year ago

mebbaid commented 2 years ago

This is a PR that fixes

When finialized, this PR should close #169

mebbaid commented 2 years ago

This is a draft PR for now. I will squash, and cancel irrelevant commits and select only unmerged commits. Once cleaned, i will put it up for review.

xEnVrE commented 1 year ago

Hi @mebbaid,

if I am not wrong this PR is also changing the files associated to the iCubGazeboV2_5_visuomanip model. Is this a mistake or is it intended? I am referring to these changes.

Thank you

mebbaid commented 1 year ago

Hi @mebbaid,

if I am not wrong this PR is also changing the files associated to the iCubGazeboV2_5_visuomanip model. Is this a mistake or is it intended? I am referring to these changes.

Thank you

Thanks for the catch @xEnVrE , indeed these changes are probably a copy mistake. Will discard them.

traversaro commented 1 year ago

@mebbaid can you rebase on top of master? It seems that there is the commit https://github.com/robotology/icub-models/pull/176/commits/f547a99c7709cd8eba0f6240b72de0c1363ce2a8 in this release that actually already belongs to master.

mebbaid commented 1 year ago

Hi @mebbaid,

if I am not wrong this PR is also changing the files associated to the iCubGazeboV2_5_visuomanip model. Is this a mistake or is it intended? I am referring to these changes.

Thank you

Hi @xEnVrE , I was indeed confused why the file changed since the output of git log --follow iCub_manual/robots/iCubGazeboV2_5_visuomanip/model.urdf gives me the following 

(base) mebbaid@IITICUBLAP213:~/robot-code/mebbaid_icub-models/icub-models$ git log --follow iCub_manual/robots/iCubGazeboV2_5_visuomanip/model.urdf
commit 0a00225459d35eb45e8be676388ee906c4dc2cb1
Author: Nicola Piga <nicolapiga@gmail.com>
Date:   Mon Mar 14 11:28:51 2022 +0100

    Fix wrong collision of 'l_hand_little_1' in iCub_manual/iCubGazeboV2_5

commit 6f1d59b59aaa024dc9117c6523e22c8baaf05f26
Author: Nicola Piga <nicolapiga@gmail.com>
Date:   Fri Mar 11 17:43:17 2022 +0100

    Fix material colors of iCub_manual/iCubGazeboV2_5_visuomanip as per https://github.com/robotology/icub-models-generator/pull/217

commit ac14772fb48d8aa887bc3b2397491e5762749745
Author: Ugo Pattacini <ugo.pattacini@iit.it>
Date:   Sun Jul 26 16:28:40 2020 +0200

    address #44

commit e0b88c461e7996003bdfe340cef9ea741f3ecf6c
Author: Nicola Piga <nicolapiga@gmail.com>
Date:   Thu Jul 23 17:11:30 2020 +0200

    Add model iCub_manual/iCubGazeboV2_5_visuomanip

with no local changes. Hopefully things should be ok now.