search

robotology / icub-models

Official URDF and SDF models of the iCub humanoid robot.
Creative Commons Attribution Share Alike 4.0 International
33 stars 34 forks source link

Old configuration files - presumably not used #185

Closed xEnVrE closed 1 year ago

xEnVrE commented 1 year ago

While I was working on https://github.com/robotology/icub-models/issues/171#issuecomment-1396944172, I noticed that there are several files inside https://github.com/robotology/icub-models/tree/devel/iCub/conf, where ideally only automatically generated file should stay, that are not updated by the GitHub action.

I am wondering whether these are really used by some of the automatically generated models or not. As an example, I think that automatically generated models are using the file:

while the repository still hosts:

having their last commit 3 years ago and still using the controlboardwrapper2.

Other files are probably not required anymore:

Should we think of removing these files in order to tidy up the configuration folder?

traversaro commented 1 year ago

Thanks for opening this issue!

To avoid having this problem again, we should delete everytime all the files in the directory of automatically generated files.

traversaro commented 1 year ago

Ok, I started tackling this with:

Once this are done, we need to actually delete the files.

xEnVrE commented 1 year ago

Once this are done, we need to actually delete the files.

Ok, meanwhile I am tackling #171 so that the manually edited robot, at least iCubGazeboV2_5_visuomanip, will only use the manually generated configuration files and, newly introduced, wrappers for the yarprobotinterface plus some of the automatically generated configuration files (those that are actually used by all the other simulated robots and can be shared).