search

robotology / icub-models

Official URDF and SDF models of the iCub humanoid robot.
Creative Commons Attribution Share Alike 4.0 International
33 stars 34 forks source link

Make iCubGazeboV_2_5_visuomanip RGB camera port names harmonized again #196

Closed xEnVrE closed 1 year ago

xEnVrE commented 1 year ago

As per the title, this restore port names for the RGB cameras of iCubGazeboV_2_5_visuomanip such that they are as in

https://github.com/robotology/icub-models/pull/45/files#diff-1e5c2f03288ab12a5b18118bc44ed0d0096511a21c7c2e02fe851c185e3de101

and not as in

https://github.com/robotology/icub-models/pull/188/files#diff-e4397ef8e3fdcf273315c11bd778759f2352f511dbf53babc3c7b2b8284fa491

where the right camera port name was changed to /icubSim/cam/right by mistake.

With this change, the port names associated to the cameras are:

registration name /icubSim/cam/left/depthImage:o
registration name /icubSim/cam/left/rgbImage:o
registration name /icubSim/cam/left/rpc:i
registration name /icubSim/cam/right/rgbImage:o
registration name /icubSim/cam/right/rgbImage:o/rpc

i.e., different from the real robot, as documented in #47, but at least harmonized.

Fixes #195

cc @traversaro @pattacini @davidegorbani

traversaro commented 1 year ago

Can you add a changelog note?

xEnVrE commented 1 year ago

Can you add a changelog note?

Done!

traversaro commented 1 year ago

Thanks!