iCub Manual Models used from build

robotology / icub-models

Official URDF and SDF models of the iCub humanoid robot.

Creative Commons Attribution Share Alike 4.0 International

33 stars 34 forks source link

iCub Manual Models used from build #43

Closed pattacini closed 4 years ago

pattacini commented 4 years ago

This PR aims to fix the use of build tree for the newly created manual models.

Further, I've also taken the chance to fix what I think is a bug as the SDF version wasn't correctly reported in the model.config files.

@traversaro @xEnVrE please have a look!

traversaro commented 4 years ago

Thanks @pattacini for handling this. Given your modifications, I guess we need to remove the line:

install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/iCub_manual/ DESTINATION share/iCub)

otherwise (for example) the non-processed iCubGazeboV2_5_visuomanip/model.config will be copied instead of the one processed that is present in the build directory, and would be already installed by the line:

install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/iCub DESTINATION share)

pattacini commented 4 years ago

That's right, I'll be doing a couple of tests more on this for confirmation and let you know asap (this afternoon).

pattacini commented 4 years ago

Test successful @traversaro ✔️