search

robotology / icub-models

Official URDF and SDF models of the iCub humanoid robot.
Creative Commons Attribution Share Alike 4.0 International
33 stars 34 forks source link

Added hand Mk3 and wrist Mk2 iCub components. #88

Closed ale-git closed 3 years ago

ale-git commented 3 years ago

Components not yet mounted on iCub have been added to automatic generation. They are built in iCub/parts folder.

ale-git commented 3 years ago

@fiorisi

fiorisi commented 3 years ago

@ale-git in icub-models we should not commit any model. Theoretically only the bot that automatically generates the models should be allowed to commit. More in detail, starting from the files contained in icub-model-generator, a continous integration service generates the URDF models and commits the URDF files in icub-models. You can have a look at the dedicated script. Furthermore, here few more details https://github.com/robotology/icub-models-generator/issues/65

traversaro commented 3 years ago

Given our discussion and @fiorisi comment, I guess we can close the issue?

traversaro commented 3 years ago

Actually, I guess that some of the changes in CMakeLists.txt may need to be done as direct PRs, as all the content of this repo outside the iCub directory is not automatically generated by https://github.com/robotology/icub-models-generator . In any case, I guess we can wait for the outcome of https://github.com/robotology/icub-models-generator/pull/203 to revisit this.