search

robotology / idyntree-yarp-tools

Tools based on the iDynTree library that depend on YARP.
GNU Lesser General Public License v2.1
6 stars 2 forks source link

Converting iDynTree (float) pixels to yarp (unsigned char). #16

Closed S-Dafarra closed 3 years ago

S-Dafarra commented 3 years ago

Fixed some deprecation warnings.

Related to https://github.com/robotology/idyntree/pull/903

traversaro commented 3 years ago

Can you bump version to 0.0.2 ?

traversaro commented 3 years ago

At least until iDynTree 5 is released, we may need to swith to compile iDynTree from source, see https://github.com/robotology/yarp-matlab-bindings/blob/master/.github/workflows/conda-ci.yml for a similar case (in that case YARP is compiled from source).

S-Dafarra commented 3 years ago

At least until iDynTree 5 is released, we may need to swith to compile iDynTree from source, see https://github.com/robotology/yarp-matlab-bindings/blob/master/.github/workflows/conda-ci.yml for a similar case (in that case YARP is compiled from source).

I created the branch devel with the initial idea of keeping there the code that is related to unreleased versions of yarp/iDynTree. On the other hand, I did not consider that the CI would have failed. It would be interesting having the CI automatically picking the development version (devel for iDynTree, master for yarp) for the code that is in the devel branch :thinking:

traversaro commented 3 years ago

At least until iDynTree 5 is released, we may need to swith to compile iDynTree from source, see https://github.com/robotology/yarp-matlab-bindings/blob/master/.github/workflows/conda-ci.yml for a similar case (in that case YARP is compiled from source).

I created the branch devel with the initial idea of keeping there the code that is related to unreleased versions of yarp/iDynTree. On the other hand, I did not consider that the CI would have failed. It would be interesting having the CI automatically picking the development version (devel for iDynTree, master for yarp) for the code that is in the devel branch 🤔

You can check the base branch of the PR, but for the time being just switching to compile from source I think it is ok.

S-Dafarra commented 3 years ago

You can check the base branch of the PR, but for the time being just switching to compile from source I think it is ok.

Done in #17.