robotology / idyntree-yarp-tools

Tools based on the iDynTree library that depend on YARP.
GNU Lesser General Public License v2.1
6 stars 2 forks source link

Added possibility to connect to WBD to display the net external wrenches #8

Closed S-Dafarra closed 3 years ago

S-Dafarra commented 3 years ago

It requires https://github.com/robotology/whole-body-estimators/pull/111, but it is not a hard constraint.

It displays 2 arrows for each wrench. One for the force (default red) one for the torque (default blue).

Example:

image

prashanthr05 commented 3 years ago

Wow!

traversaro commented 3 years ago

Just a curiosity, where does the requirement for iDynTree 3.1 comes from?

traversaro commented 3 years ago

I think this functionality is quite important for all @robotology/iit-dynamic-interaction-control, and can be finally mean that we can stop using the iCubGui for debugging if the external force estimation coming from WBD.

traversaro commented 3 years ago

cc @Nicogene @pattacini this was the new drop-in for iCubGui that I mentioned in some meetings, I guess this functionality can be helpful for iCub 3 or in general when running WBD on robot models not supported by iCubGui.

S-Dafarra commented 3 years ago

Just a curiosity, where does the requirement for iDynTree 3.1 comes from?

I needed to bump the required version because I used the methods introduced in https://github.com/robotology/idyntree/pull/849. I thought to directly use the latest release then.

pattacini commented 3 years ago

cc @Nicogene @pattacini this was the new drop-in for iCubGui that I mentioned in some meetings, I guess this functionality can be helpful for iCub 3 or in general when running WBD on robot models not supported by iCubGui.

This looks like a very nice piece of SW indeed. Just want to point out that for replacing the current iCubGui we'd need also to replicate the layer responsible for creating objects. In iCubGui we can only deal with simple objects and trajectories, so maybe this can be taken into account as well.

S-Dafarra commented 3 years ago

@prashanthr05 let me know if the modifications are ok for you!

prashanthr05 commented 3 years ago

@prashanthr05 let me know if the modifications are ok for you!

Yep. LGTM!!

S-Dafarra commented 3 years ago

@traversaro I would squash and merge. Is that ok with you?

traversaro commented 3 years ago

@traversaro I would squash and merge. Is that ok with you?

Ok!