search

robotology / idyntree

Multibody Dynamics Library designed for Free Floating Robots
BSD 3-Clause "New" or "Revised" License
155 stars 65 forks source link

Fix 1137 #1139

Closed mebbaid closed 6 months ago

mebbaid commented 6 months ago

This PR handles limitations imposed by Irrlicht on the number of vertices per rendered mesh. Related issue #1137

S-Dafarra commented 6 months ago

I think there might be an issue with assimp on Windows

LINK : fatal error LNK1181: cannot open input file 'assimp.lib' [D:\a\idyntree\idyntree\build\src\visualization\idyntree-visualization.vcxproj]
traversaro commented 6 months ago

I think there might be an issue with assimp on Windows

LINK : fatal error LNK1181: cannot open input file 'assimp.lib' [D:\a\idyntree\idyntree\build\src\visualization\idyntree-visualization.vcxproj]

I guess this will be fixed by https://github.com/robotology/idyntree/pull/1139/files#r1446594328 .

traversaro commented 6 months ago

Thanks a lot for the great work @mebbaid @S-Dafarra !

It is not a big problem in this case, but in the future if you could avoid making big whitespace/indent changes like the one in https://github.com/robotology/idyntree/pull/1139/commits/2b644e9eef218144bdef82ca9ebca9934021e949 mixed with actual changes it would be great, as the big whitespace/indentation changes make the actual changes difficult to read.

In the merge, can I squash together the commits? Thanks!

mebbaid commented 6 months ago

but in the future if you could avoid making big whitespace/indent changes like the one in https://github.com/robotology/idyntree/commit/2b644e9eef218144bdef82ca9ebca9934021e949 mixed with actual changes it would be great, as the big whitespace/indentation changes make the actual changes difficult to read.

yeah, i relied too much on vscode for formating. But should pay attention to that.

In the merge, can I squash together the commits? Thanks!

yeah, thanks a lot!

traversaro commented 6 months ago

but in the future if you could avoid making big whitespace/indent changes like the one in 2b644e9 mixed with actual changes it would be great, as the big whitespace/indentation changes make the actual changes difficult to read.

yeah, i relied too much on vscode for formating. But should pay attention to that.

It is partially fault of iDynTree itself, we should just add a .clang-format file and live happy.