search

robotology / idyntree

Multibody Dynamics Library designed for Free Floating Robots
BSD 3-Clause "New" or "Revised" License
166 stars 66 forks source link

Remove duplicated isFakeLinks and removeFakeLinks from the URDF parser #556

Closed traversaro closed 4 years ago

traversaro commented 5 years ago

The removeFakeLinks function added in https://github.com/robotology/idyntree/pull/103 , for some reason was duplicated in the URDFDocument.cpp in https://github.com/robotology/idyntree/pull/460/files#diff-e36c73e786c46fd51eafe944b2bcc479R240/https://github.com/robotology/idyntree/pull/460/files#diff-0edb8e64e90cc754894d259a6274bc15L751. There was probably no reason for that, it was just a left over.

We should remove this duplication so that we just maintain one (public) copy.

traversaro commented 4 years ago

Fixed by https://github.com/robotology/idyntree/pull/611 .