search

robotology / osqp-eigen

Simple Eigen-C++ wrapper for OSQP library
https://robotology.github.io/osqp-eigen/
BSD 3-Clause "New" or "Revised" License
381 stars 112 forks source link

Import AddUninstallTarget.cmake from YCM v0.14.1 to fix compilation with ninja #120

Closed traversaro closed 2 years ago

traversaro commented 2 years ago

From https://github.com/robotology/ycm/blob/v0.14.1/modules/AddUninstallTarget.cmake

The osqp-eigen PR https://github.com/robotology/osqp-eigen/pull/117 introduced a ninja-related regression as it ported from YCM the PR https://github.com/robotology/ycm/issues/169 without porting the related commit https://github.com/robotology/ycm/commit/f2c61b1b9f5b2a7935bf79d1d43a68a218225804 that is a fix for https://github.com/robotology/ycm/issues/240 . To avoid the problem, I just import the module from the latest YCM release.

Fix https://github.com/robotology/robotology-superbuild/issues/1153 .

traversaro commented 2 years ago

fyi @mhubii @GiulioRomualdi

GiulioRomualdi commented 2 years ago

Thank you @traversaro