robotology / osqp-eigen

Simple Eigen-C++ wrapper for OSQP library
https://robotology.github.io/osqp-eigen/
BSD 3-Clause "New" or "Revised" License
381 stars 112 forks source link

Make the code compatible with OSQP v1.0.0 #131

Closed gergondet closed 1 year ago

gergondet commented 1 year ago

This PR updates osqp-eigen to be compatible with OSQP v1.0.0 (currently in beta). I have kept the API of osqp-eigen (almost) identical

The following things are known to not work (and afaik cannot be done with OSQP v1.0.0)

Otherwise I can at least confirm the unit tests pass but I haven't tried much more.

traversaro commented 1 year ago

Thanks a lot @gergondet ! fyi @GiulioRomualdi @S-Dafarra

traversaro commented 1 year ago

Sorry for the unrelated CI failure, it should be fixed by https://github.com/robotology/osqp-eigen/pull/133 .

gergondet commented 1 year ago

Thanks @traversaro

I have rebased on the lastest master and it all seems green now (the latest Windows failure is a network hiccup I guess)

The Codacity warnings are wrong, the members are used since the structure replaces the OSQPData structure from the old API

GiulioRomualdi commented 1 year ago

Thank you @gergondet! Your work is much appreciated, and we're grateful for the time and effort you put into it! I want to apologize for the long delay in reviewing and merging your PR.