robotology / osqp-eigen

Simple Eigen-C++ wrapper for OSQP library
https://robotology.github.io/osqp-eigen/
BSD 3-Clause "New" or "Revised" License
395 stars 118 forks source link

Fix osqp_vendor dependency in package.xml #139

Open ptenbrock opened 1 year ago

ptenbrock commented 1 year ago

When running rosdep install, there is an error regarding the osqp dependency:

ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
osqp-eigen: Cannot locate rosdep definition for [osqp]
traversaro commented 1 year ago

Thanks for reporting the problem @ptenbrock ! The package.xml was added back in time (https://github.com/robotology/osqp-eigen/pull/109) by @wxmerkt. I think that in his workflow osqp was build as part of the catkin workspace, but probably @wxmerkt can comment on this PR.

wxmerkt commented 1 year ago

I believe this needs to be conditional on the ROS_VERSION variable: osqp for ROS1, osqp_vendor for ROS2.

traversaro commented 1 year ago

I believe this needs to be conditional on the ROS_VERSION variable: osqp for ROS1, osqp_vendor for ROS2.

Can you do this change @ptenbrock ? Thanks!

ptenbrock commented 1 year ago

I checked a few distros, and they all have osqp_vendor as the rosdep-key (I couldn't find osqp/osqp_vendor for melodic):

wxmerkt commented 1 year ago

Ok, then this has changed since I set this up something back. Happy to go ahead with the change

traversaro commented 4 months ago

Thanks @wxmerkt and sorry for the radio silence. So it is ok to merge this as it is, that would not be a problem if someone is building osqp+osqp-eigen as part of a catkin or colcon workspace?

wxmerkt commented 4 months ago

@traversaro Yes, good to go ahead.