search

robotology / osqp-eigen

Simple Eigen-C++ wrapper for OSQP library
https://robotology.github.io/osqp-eigen/
BSD 3-Clause "New" or "Revised" License
393 stars 117 forks source link

Fix #12 #15

Closed GiulioRomualdi closed 5 years ago

GiulioRomualdi commented 6 years ago

This Fixes #12 and MPCExample.cpp

GiulioRomualdi commented 5 years ago

It seems that Travis is not able to execute make test when Compiler: gcc Xcode: xcode9.4 C++ is chosen https://travis-ci.org/GiulioRomualdi/osqp-eigen/jobs/446635155. This behavior does not happen with Linux (any Ubuntu version) and Compiler: clang Xcode: xcode9.4 C++ https://travis-ci.org/robotology/osqp-eigen/builds/446635175 @traversaro do you have any suggestions?

traversaro commented 5 years ago

I guess if you have TRAVIS_CMAKE_GENERATOR="Xcode" then make test is not a valid command, as the generated project is an Xcode project. i suggest to use ctest or even better ctest --output-on-failure --config ${TRAVIS_BUILD_TYPE} (see for example https://github.com/robotology/idyntree/blob/master/.ci/script.sh#L31). Note that the --config flag passed to the build and test phases is useful only to support multiple-config generators such as Xcode (https://cgold.readthedocs.io/en/latest/glossary/multi-config.html).

GiulioRomualdi commented 5 years ago

Thanks @traversaro, the right command is ctest --output-on-failure --build-config ${TRAVIS_BUILD_TYPE}.

GiulioRomualdi commented 5 years ago

I think we can merge this PR