robotology / osqp-eigen

Simple Eigen-C++ wrapper for OSQP library
https://robotology.github.io/osqp-eigen/
BSD 3-Clause "New" or "Revised" License
381 stars 112 forks source link

I'm using osqp-eigen v0.7.0, wondering if Hessian Matrix is supporting only symmetric matrix, rather than upper triangular matrix. #152

Open ZhiDaoYongYuan opened 8 months ago

ZhiDaoYongYuan commented 8 months ago

My partial code as follows:

// symmetric matrix
for (int i = 0; i < n - 1; ++i)
{
    hessian.insert(i, i + 1) = 1.0;
    hessian.insert(i + 1, i) = 1.0;
}
// upper triangular matrix
for (int i = 0; i < n - 1; ++i)
{
    hessian.insert(i, i + 1) = 2.0;
}

When I used the symmetric matrix, I got the true solution(I guess). Instead, solver return status: problem non convex while using upper triangular matrix.

traversaro commented 8 months ago

Strictly speaking according to the documentation the hessian matrix is required to be symmetric, but looking in the code actually only an upper triangular view is used (see https://github.com/robotology/osqp-eigen/blob/a752c5e6353cae6176578488a1fa641d3b9cf0b9/include/OsqpEigen/Data.tpp#L40-L44), even if this behavior is not part of the public docs so it could change without notice.

Are you sure that in your example you are actually passing the two matrices in the two cases? Can you provide a full example in the two cases, instead an incomplete snippet of code? Thanks!

S-Dafarra commented 8 months ago

Hi @ZhiDaoYongYuan, did you fill the diagonal as well? If $n=2$, the corresponding matrix would be

\begin{bmatrix}
0 & 2 \\
2 & 0 
\end{bmatrix}

whose eigenvalues are +2 and -2. Hence the matrix would not be positive semidefinite. So I would say that the error message is correct. I am not sure why it did not print it in the first case.