search

robotology / osqp-eigen

Simple Eigen-C++ wrapper for OSQP library
https://robotology.github.io/osqp-eigen/
BSD 3-Clause "New" or "Revised" License
381 stars 112 forks source link

Fix math and code markdown code in mpc.md #160

Closed MarceloContreras closed 1 month ago

MarceloContreras commented 3 months ago

Many math expression, code references and the image were broken in the markdown viz. Now fixed

traversaro commented 3 months ago

Thanks @MarceloContreras ! This fixes the rendering on GitHub itself, but that page was written with the main goal of being rendered in https://robotology.github.io/osqp-eigen/md_pages_mpc.html, do you have any idea if that still works?

fyi @GiulioRomualdi

MarceloContreras commented 3 months ago

I believe that my push brokes the render in your github.io as it is powered by Doxygen and it requires to wrap equations with \f[]. It seems to be a regular compatibility issue between Doxygen docs and Github.

traversaro commented 3 months ago

I believe that my push brokes the render in your github.io as it is powered by Doxygen and it requires to wrap equations with \f[]. It seems to be a regular compatibility issue between Doxygen docs and Github.

Ack, in this case probably that I guess it is not ok for us to merge the PR as it is if it will break https://robotology.github.io/osqp-eigen/md_pages_mpc.html . Do you have any alterntive solution?

traversaro commented 1 month ago

Hello @MarceloContreras, do you plan to follow up? If not, no problem, just asking so we can close the PR if you do not plan to follow up.

MarceloContreras commented 1 month ago

I won't follow it up. I have no issues in closing the issue.

traversaro commented 1 month ago

Ok, thanks!