robotology / osqp-eigen

Simple Eigen-C++ wrapper for OSQP library
https://robotology.github.io/osqp-eigen/
BSD 3-Clause "New" or "Revised" License
393 stars 117 forks source link

Deleted move constructor of Solver #37

Closed chibi314 closed 4 years ago

chibi314 commented 5 years ago

https://github.com/robotology/osqp-eigen/blob/master/include/OsqpEigen/Solver.hpp The move constructor of class Solver is implicitly deleted. Therefore the instance of Solver is unable to move. Is there any reason of forbidding move operation? If no, can I add default move constructor?

GiulioRomualdi commented 4 years ago

Hi @chibi314 sorry for the late response, I completely forgot the issue. There is no reason. I will add it along with the copy constructor, copy assignment operator and move assignment operator in the next future.

GiulioRomualdi commented 4 years ago

Hi @chibi314 #47 should solve your issue