search

robotology / peripersonal-space

This repository deals with the implementation of peripersonal space representations on the iCub humanoid robot.
GNU General Public License v2.0
1 stars 3 forks source link

OpenCV-3.x.y compatibility #19

Closed vicentepedro closed 8 years ago

vicentepedro commented 8 years ago

Hi all!

I tried to compile the repository using OpenCV 3.x.y.

I got the usual errors due to the conversion from IplImage to Mat using the constructor method.

I don't know if you want to support it. ;)

pattacini commented 8 years ago

Hi @vicentepedro

Thanks for reporting on this issue. I and @alecive will be soon working to get PPS upgraded to the use of opencv-3.x.y.

pattacini commented 8 years ago

@alecive @matejhof Concerning this overhaul, we have to first merge the feature branch into master (see #20) and soon afterwards proceed with the upgrade to opencv-3.x.y.

matejhof commented 8 years ago

For now, I discovered that it seems it is only the fingertipTracker module with this problem. That one is not necessary for the core functionality, so we can just comment its compilation out.

pattacini commented 8 years ago

See #21.

pattacini commented 8 years ago

Should be fixed.

alecive commented 8 years ago

@vicentepedro now it is fixed only in the feature/WYSIWYD branch, but as soon as #20 is fixed, also the master branch will be up-to-date with OpenCV 3.*

pattacini commented 8 years ago

For the #20, @alecive could you do that? :smile:.

alecive commented 8 years ago

I'm waiting for @matejhof to come back from the review meeting because I can merge remotely but I cannot test it :stuck_out_tongue:

pattacini commented 8 years ago

You could do already the first two bullet points though.

pattacini commented 8 years ago

@vicentepedro @alecive Unlike I said before, I first fixed the opencv related issues. This was because only fingertipTracker was affected.

alecive commented 8 years ago

@vicentepedro now the feature/WYSIWID branch has been merged onto master, and the code should be OpenCV 3.* compatible. Please report back if you still have any issues!