Closed pattacini closed 8 years ago
@pattacini we tagged the repo when we acquired data for the pps-paper. I think that, at least until published, we should keep them (plus, they don't hurt).
Ok, after discussing with @alecive and the latest commit regarding demoAvoidance, I need to test the demoAvoidance on the robot and the functionality of the 2D representation. After that, we should be able to merge.
demoAvoidance in feature/WYSIWYD works like a charm. make sure you take the updated PPS_with_Optical_Flow script on board when merging - new port name to connect to is:
<from>/visuoTactileRF/pps_events_aggreg:o</from>
<to>/avoidance/data:i</to>
1D learning works fine in feature/WYSIWYD
2D learning seems fine two (it's hard to precisely see the effects of velocity because of the low res of velocity, 4 bins, and the noise on the velocity estimation). So we can merge feature/WYSIWYD into master I think!
Cool! @alecive are you in charge of this merge?
Great! I will do that ASAP (that might not necessarily mean before the end of this week, though :) )
I am working on the merge. @matejhof two stylistic things I would like to point out:
Try to stick with the same convention I am using throughout the repo regarding brackets. I.e this is what I am using :
for (whatever)
{
....
}
This is what you have in the virtualContactGeneration
:
for (whatever){
....
}
Now, I don't really care about which one is better, since they are equivalent, and it all comes up to a matter of personal preferences and habits. What I care about is to at least be consistent with the other 95% of the code - which uses the first convention, because also this helps in code readability :smile:
Thanks!
@alecive is definitely right and I do put forward his requests.
Please, @matejhof, do not underestimate these factors. Complying with these rules discriminates code that will die soon from code that will represent a robust building block :smile: (really!)
When extending/modifying others' code, you must adapt yourself to the conventions you find in it.
Ok I did it! It was long and painful and I couldn't test it but at least it compiles. Also, @matejhof other two things:
We have to:
1Dstable
and delete the branch.feature/WYSIWYD
intomaster
.@alecive @matejhof