Fixing feature/WYSIWYD

[pattacini]

• Lots of warnings fixed, some of which are quite significant.
• Made opencv-3.x.y friendly.

The idea is to first merge these fixes into feature/WYSIWYD and then proceed with merging feature/WYSIWYD into master.

@alecive and @matejhof please have a look at this.

• [x]  General Comment
• <img border=0 src='https://avatars.githubusercontent.com/u/4378663?v=3' height=16 width=16'> Wow all of these were warning on windows? You should have done the pull request before! A question: you replaced

#include <cv.h>
#include <highgui.h>

with #include <opencv2/opencv.hpp>. Why didn't you replace them with:

#include <opencv2/core/core.hpp>
#include <opencv2/highgui/highgui.hpp>

? A part from that, PR approved.

• <img border=0 src='https://avatars.githubusercontent.com/u/4378663?v=3' height=16 width=16'> :shipit:
• <img border=0 src='https://avatars.githubusercontent.com/u/3738070?v=3' height=16 width=16'> The highgui.hpp header file is simply not necessary for the compilation :wink:.

   

[alecive]

Wow all of these were warning on windows? You should have done the pull request before! A question: you replaced

#include <cv.h>
#include <highgui.h>

with #include <opencv2/opencv.hpp>. Why didn't you replace them with:

#include <opencv2/core/core.hpp>
#include <opencv2/highgui/highgui.hpp>

?

A part from that, PR approved.

[alecive]

:shipit:

[pattacini]

The highgui.hpp header file is simply not necessary for the compilation :wink:.

[pattacini]

:+1: