search

robotology / robometry

Telemetry suite for logging data from your robot 🤖
https://robotology.github.io/robometry
Other
14 stars 9 forks source link

telemetryDeviceDumper: fix xml files and add xml files for running with gazebo #108

Closed Nicogene closed 3 years ago

Nicogene commented 3 years ago

Today @AlexAntn spotted that save_period 120 make fail the configuration since it is not a float(120.0 is fine, we may relax it)

I moreover added the XML and in files for running the tdd with gazebo.

Just:

$ gazebo
$ cd yarp-telemetry/src/telemetryDeviceDumper/app
$ yarprobotinterface

(We can then think where to install those files)

traversaro commented 3 years ago

Today @AlexAntn spotted that save_period 120 make fail the configuration since it is not a float(120.0 is fine, we may relax it)

Shouldn't we simply add a isInt or similar in https://github.com/robotology-playground/yarp-telemetry/blob/master/src/telemetryDeviceDumper/TelemetryDeviceDumper.cpp#L133 ?

Nicogene commented 3 years ago

Shouldn't we simply add a isInt or similar in https://github.com/robotology-playground/yarp-telemetry/blob/master/src/telemetryDeviceDumper/TelemetryDeviceDumper.cpp#L133 ?

We have to check if isInt fails if you put 0.3 for example (cc @drdanz ) but yes we could check both eventually

traversaro commented 3 years ago

Shouldn't we simply add a isInt or similar in https://github.com/robotology-playground/yarp-telemetry/blob/master/src/telemetryDeviceDumper/TelemetryDeviceDumper.cpp#L133 ?

We have to check if isInt fails if you put 0.3 for example (cc @drdanz ) but yes we could check both eventually

I think that indeed isInt will fail for 0.3. but I guess we should accept both int and double, right? If isInt is true do asInt, if isFloating is true do asFloat etc etc.