robotology / robometry

Telemetry suite for logging data from your robot 🤖
https://robotology.github.io/robometry
Other
14 stars 9 forks source link

Fix ini generation and compilation #130

Closed Nicogene closed 3 years ago

Nicogene commented 3 years ago

This PR fixes some issues( #127 and #128)

In particular for #127 this is what I got

Directory: C:\Users\ngenesio\robotology\yarp-telemetry\build\x64-Debug\share\yarp\plugins

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----         4/23/2021   1:31 PM            164 telemetryDeviceDumper.ini
-a----         4/23/2021   1:31 PM            190 yarp-telemetry.ini

The latter one contains:

###### This file is automatically generated by CMake.
[search yarp-telemetry]
path "C:/Users/ngenesio/robotology/yarp-telemetry/build/x64-Debug/lib/yarp"
extension ".dll"
type "shared"

Is it correct?

drdanz commented 3 years ago

The only annoying thing about calling find_package(YARP) more than once is that the "Found YARP" line will be printed multiple times. I suggest calling it once... something like

find_package(YARP ${YARP_REQUIRED_VERSION} COMPONENTS conf OPTIONAL_COMPONENTS os sig dev REQUIRED)

you should then pay attention to check

if(YARP_os_FOUND)

etc