search

robotology / robometry

Telemetry suite for logging data from your robot 🤖
https://robotology.github.io/robometry
Other
14 stars 9 forks source link

Remove YARP_telemetry_DEPRECATED_API definition #133

Closed drdanz closed 3 years ago

drdanz commented 3 years ago

I realized that the YARP_DEPRECATED_API definition is broken, and won't work anyway outside YARP_os AFAIK, this is the only place outside YARP where this definition is used, therefore I'm planning to change this to a proper EXPORT/IMPORT definition in YARP master, and I'm not sure if it is possible to do this ensuring the compatibility, without breaking the API.

This means that current definition will work with YARP 3.4 only, and the new definition will require YARP master which is unreleased yet. Therefore I suggest to remove these 2 lines (I don't think there is any deprecated API in yarp_telemetry yet), and to wait until YARP 3.5 is released to depend on YARP 3.5 and fix the definition.

drdanz commented 3 years ago

Just for reference, this is current implementation:

https://github.com/robotology/yarp/blob/8bde9a1f1512ca3097e818c2786c6f9f0ea39cf7/src/libYARP_conf/src/yarp/conf/api.h.in#L126-L132

As you can see, it depends on YARP_os_API which is undefined here