robotology / robometry

Telemetry suite for logging data from your robot 🤖
https://robotology.github.io/robometry
Other
14 stars 9 forks source link

Introduce the `matioCpp::Span` in the interface of yarp-telemetry #144

Closed GiulioRomualdi closed 2 years ago

GiulioRomualdi commented 2 years ago

This closes #49

this is the first step towards https://github.com/ami-iit/bipedal-locomotion-framework/issues/189

cc @traversaro @S-Dafarra @Nicogene

S-Dafarra commented 2 years ago

What if we have both the possibility to pass a vector and a span? We would probably need some SFINAE hack to avoid ambiguity (i.e. the span method should not work if you are passing a std::vector), but at least in this way we avoid API breaks, and we don't even need to change all the examples :thinking:

GiulioRomualdi commented 2 years ago

What if we have both the possibility to pass a vector and a span? We would probably need some SFINAE hack to avoid ambiguity (i.e. the span method should not work if you are passing a std::vector), but at least in this way we avoid API breaks, and we don't even need to change all the examples thinking

Hi @S-Dafarra I answered here: https://github.com/robotology/yarp-telemetry/pull/144#discussion_r768457176

GiulioRomualdi commented 2 years ago

In https://github.com/robotology/yarp-telemetry/pull/144/commits/39e96dce98f6798187efba538443ae023df46619 and https://github.com/robotology/yarp-telemetry/pull/144/commits/8eca2ead72f31bc3fd013cd9f067ab58c92bdbb9 I restored the missing methods and I implemented the std::initializer_list methods

https://github.com/robotology/yarp-telemetry/pull/144/commits/a48800132cdac90f508e68018ecad4f2f2833640 reintroduces the back-compatibility for the tests and the examples

Nicogene commented 2 years ago

The failure of the CI seems unrelated, I restarted it

GiulioRomualdi commented 2 years ago

I should update the changelog before the merge

Done in https://github.com/robotology/yarp-telemetry/pull/144/commits/2615052fe3085ef813f703c1cf37bc3c5d2a9706

Nicogene commented 2 years ago

Merged, thanks!