search

robotology / robometry

Telemetry suite for logging data from your robot 🤖
https://robotology.github.io/robometry
Other
14 stars 9 forks source link

Fixed bug preventing the save of files when multiple channels are empty. #169

Closed S-Dafarra closed 2 years ago

S-Dafarra commented 2 years ago

I just noticed that since https://github.com/robotology/yarp-telemetry/pull/146, when running the example telemetry_buffer_manager_conf_file_example, we have the following output

==13014== 
==13014== HEAP SUMMARY:
==13014==     in use at exit: 0 bytes in 0 blocks
==13014==   total heap usage: 62 allocs, 62 frees, 104,173 bytes allocated
==13014== 
==13014== All heap blocks were freed -- no leaks are possible
==13014== 
==13014== For lists of detected and suppressed errors, rerun with: -s
==13014== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
==13019== Memcheck, a memory error detector
==13019== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==13019== Using Valgrind-3.15.0 and LibVEX; rerun with -h for copyright info
==13019== Command: ./telemetry_buffer_manager_conf_file_example
==13019== 
Starting loop
two does not contain data, skipping
two does not contain data, skipping
one does not contain data, skipping
HDF5-DIAG: Error detected in HDF5 (1.10.4) thread 110835456:
  #000: ../../../src/H5G.c line 323 in H5Gcreate2(): unable to create group
    major: Symbol table
    minor: Unable to initialize object
  #001: ../../../src/H5Gint.c line 157 in H5G__create_named(): unable to create and link to group
    major: Symbol table
    minor: Unable to initialize object
  #002: ../../../src/H5L.c line 1572 in H5L_link_object(): unable to create new link to object
    major: Links
    minor: Unable to initialize object
  #003: ../../../src/H5L.c line 1813 in H5L__create_real(): can't insert link
    major: Links
    minor: Unable to insert object
  #004: ../../../src/H5Gtraverse.c line 851 in H5G_traverse(): internal path traversal failed
    major: Symbol table
    minor: Object not found
  #005: ../../../src/H5Gtraverse.c line 627 in H5G__traverse_real(): traversal operator failed
    major: Symbol table
    minor: Callback failed
  #006: ../../../src/H5L.c line 1608 in H5L__link_cb(): name already exists
    major: Links
    minor: Object already exists
Error: [matioCpp::File::write] Failed to write the variable to the file.
two does not contain data, skipping
one does not contain data, skipping
HDF5-DIAG: Error detected in HDF5 (1.10.4) thread 89835392:
  #000: ../../../src/H5G.c line 323 in H5Gcreate2(): unable to create group
    major: Symbol table
    minor: Unable to initialize object
  #001: ../../../src/H5Gint.c line 157 in H5G__create_named(): unable to create and link to group
    major: Symbol table
    minor: Unable to initialize object
  #002: ../../../src/H5L.c line 1572 in H5L_link_object(): unable to create new link to object
    major: Links
    minor: Unable to initialize object
  #003: ../../../src/H5L.c line 1813 in H5L__create_real(): can't insert link
    major: Links
    minor: Unable to insert object
  #004: ../../../src/H5Gtraverse.c line 851 in H5G_traverse(): internal path traversal failed
    major: Symbol table
    minor: Object not found
  #005: ../../../src/H5Gtraverse.c line 627 in H5G__traverse_real(): traversal operator failed
    major: Symbol table
    minor: Callback failed
  #006: ../../../src/H5L.c line 1608 in H5L__link_cb(): name already exists
    major: Links
    minor: Object already exists
Error: [matioCpp::File::write] Failed to write the variable to the file.
==13019== 
==13019== HEAP SUMMARY:
==13019==     in use at exit: 1,864 bytes in 3 blocks
==13019==   total heap usage: 8,2[95](https://github.com/robotology/yarp-telemetry/runs/5738646897?check_suite_focus=true#step:17:95) allocs, 8,292 frees, 6,874,213 bytes allocated
==13019== 
==[130](https://github.com/robotology/yarp-telemetry/runs/5738646897?check_suite_focus=true#step:17:130)19== LEAK SUMMARY:
==13019==    definitely lost: 0 bytes in 0 blocks
==13019==    indirectly lost: 0 bytes in 0 blocks
==13019==      possibly lost: 0 bytes in 0 blocks
==13019==    still reachable: 1,864 bytes in 3 blocks
==13019==         suppressed: 0 bytes in 0 blocks
==13019== Reachable blocks (those to which a pointer was found) are not shown.
==13019== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==13019== 
==13019== For lists of detected and suppressed errors, rerun with: -s
==13019== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

Digging a bit into that error, it turned out that it was due to the fact that the Struct we were trying to save in the file was having two fields with the same name unnamed_struct. This was due to the logic of createElementStruct returning an empty Struct when a channel is empty. The problem is that if two channels are empty, the struct appears to have two fields with the same name, causing issues when saving.

I took the occasion also to add a bunch of checks to make sure that the saving is successfull.

Nicogene commented 2 years ago

Merged, thanks!