search

robotology / robometry

Telemetry suite for logging data from your robot 🤖
https://robotology.github.io/robometry
Other
14 stars 9 forks source link

Fix number of samples #187

Closed DanielePucci closed 10 months ago

DanielePucci commented 10 months ago

This should fix the number of samples being saved in the snippet examples. All examples, in fact, claim to save 3 samples while all 'for' loops were from 0 to 10.

S-Dafarra commented 10 months ago

Actually, I believe that the problem is not in the number of samples, but a missing detail. If you specify that you want to save 3 samples, robometry will save a file with three entries, even if you push 10 times. It will simply save the last three items. This behavior may not be properly specified in the README.

Moreover, if you enable the autosave option, it will create a new file every time you push 3 samples. Hence, when pushing 10, you should expect three files with 3 samples each, and 1 file with the last item (triggering the manual "save").

Also this might not be properly specified in the README.

By forcing the for loops to run fr three elements does not improve the clarity in this sense.

Another issue with the README is that in this line https://github.com/robotology/robometry/blob/29646dc3d54037f7ddc8f173f4a01cbd82ba3c78/README.md#L84 n_samples should be substituted with 3.

Nicogene commented 10 months ago

I am merging this and for what @S-Dafarra said I opened a dedicated issue, feel free to fill up the missing informations in the readme