search

robotology / robots-configuration

Contains robots configuration files
BSD 3-Clause "New" or "Revised" License
14 stars 69 forks source link

Add explicit period parameter(0.01 s) for the controlboard_nws_yarp #379

Closed Nicogene closed 2 years ago

Nicogene commented 2 years ago

This PR addresses #378

Please review code

traversaro commented 2 years ago

fyi @GiulioRomualdi @S-Dafarra

pattacini commented 2 years ago

cc @xEnVrE for iCubGenova01

Nicogene commented 2 years ago

@pattacini I removed R1 from the PR, and I checked iCubTemplates/iCubTemplateV6_0 and the only wrappers in the template are the ones of FT and inertials

S-Dafarra commented 2 years ago

@xEnVrE, @S-Dafarra, @GiulioRomualdi are you willing to do a quick test?

On it

xEnVrE commented 2 years ago

@pattacini tested on iCubGenova01 (excluding legs and the left arm that is not available at the moment).

The difference in timestamps from a yarpdatadumper log (configured to collect transmission times) reads, e.g., 0.010070085525512695. Seems alright.

pattacini commented 2 years ago

@pattacini tested on iCubGenova01 (excluding legs and the left arm that is not available at the moment).

The difference in timestamps from a yarpdatadumper log (configured to collect transmission times) reads, e.g., 0.010070085525512695. Seems alright.

Super! Thanks heaps.

S-Dafarra commented 2 years ago

I tested the walking on iCubGenova09 and it seems to be ok!

pattacini commented 2 years ago

I tested the walking on iCubGenova09 and it seems to be ok!

Thanks! Merging...