search

robotology / robots-configuration

Contains robots configuration files
BSD 3-Clause "New" or "Revised" License
14 stars 69 forks source link

Replace `analogServer` with `multipleanalogsensorsserver` for publishing FT data – Stint 1 #470

Closed Nicogene closed 1 year ago

Nicogene commented 1 year ago

Task description

As reported by @traversaro in https://github.com/robotology/icub-models/issues/198, some real robots publish FT data using the old(and deprecated) nws analogServer. This porting to multipleanalogsensorsserver has been already done for the simulated robots: https://github.com/robotology/icub-models-generator/pull/231 We should change the xml files in order to align the simulated robot to the real ones and get rid of an nws that will be removed in next releases.

Definition of done

The changes have been made, the PR has been merged

cc @traversaro @pattacini @gabrielenava

pattacini commented 1 year ago

/remind next Monday

octo-reminder[bot] commented 1 year ago

⏰ Reminder Monday, April 17, 2023 10:00 AM (GMT+02:00)

octo-reminder[bot] commented 1 year ago

🔔 @pattacini

Nicogene commented 1 year ago

PR opened: https://github.com/robotology/robots-configuration/pull/482

To be tested on iCubGenova11

Nicogene commented 1 year ago

I noticed that wholebodydynamics in icub-main has never been ported to the usage of MAS server/client:

https://github.com/robotology/icub-main/blob/ec6123471ee3cf212ef45fdda772e2453ed97208/src/modules/wholeBodyDynamics/observerThread.cpp#L411-L433

So maybe we need to adapt it before doing this porting

cc @traversaro @pattacini

Nicogene commented 1 year ago

PR merged ✔️