fixed calibrator for CAN device

robotology / robots-configuration

Contains robots configuration files

BSD 3-Clause "New" or "Revised" License

14 stars 69 forks source link

Closed davidetome closed 1 year ago

davidetome commented 1 year ago

This PR fixes the calibrator for CAN devices on these robots :

davidetome commented 1 year ago

Hi @pattacini !

I can still see the use of parametricCalibratorETH on the other parts of the robot iCubNancy01. Could you fix them as well?

The other parts are equipped w/ EMS so I thought that was right to leave Eth , only the head is CAN based. Isn't it?

Also, given that this is a fix, would you mind rebasing your PR against the upstream master instead of devel?

Sure

pattacini commented 1 year ago

The other parts are equipped w/ EMS so I thought that was right to leave Eth , only the head is CAN based. Isn't it?

I don't know actually. I assumed it was a full CAN robot. If you confirm that the other parts are ETH based, that's ok!