Update ergocubSN000 battery conf files

robotology / robots-configuration

Contains robots configuration files

BSD 3-Clause "New" or "Revised" License

14 stars 69 forks source link

Update ergocubSN000 battery conf files #573

Closed MSECode closed 1 year ago

MSECode commented 1 year ago

This PR brings the following changes for ergoCubSN000 (I suppose these can be copied as they are in ergocubSN001 - after revision):

Add conf files for bat and bms in hw and wrapper
Update the yarprobotinterface conf files
Set to use CAN2:1
Define separate ports on wrapppers for bat and bms devices

MSECode commented 1 year ago

cc: @valegagge Correlated to one of the points of issue: https://github.com/icub-tech-iit/project-ergocub/issues/129

pattacini commented 1 year ago

Thanks for the quick fix @MSECode 👍🏻 The CI is now ok ✅

I'll keep the PR in changes requested to address the following:

After her review, @MSECode, can you please update the PR in order to already ship the same updates for ergoCubSN001?

MSECode commented 1 year ago

Thanks for the quick fix @MSECode 👍🏻 The CI is now ok ✅

I'll keep the PR in changes requested to address the following:

After her review, @MSECode, can you please update the PR in order to already ship the same updates for ergoCubSN001?

Oks, I just commit the update for ergoCubSN001 as well

valegagge commented 1 year ago

We need also to update the robots-configuration template, but we'll address this in another PR asap