robotology / robots-configuration

Contains robots configuration files
GNU General Public License v2.0
14 stars 68 forks source link

Wrong eyes joint names for iCubGenova11 #582

Closed xEnVrE closed 8 months ago

xEnVrE commented 8 months ago

For some reason, the name of the eyes version and vergence for this robot are eyes_vers and eyes_verg

https://github.com/robotology/robots-configuration/blob/0891fbec0448283c5f62fe91f6b7c4e98b4cac8e/iCubGenova11/hardware/mechanicals/head-eb21-j2_5-mec.xml#L12

which are different from:

This is creating issues when trying to use the same software in simulation and on the real setup as joints names are different.

Can I open a PR to fix that?

cc @pattacini

sgiraz commented 8 months ago

Hi @xEnVrE,

It seems that the typo exists from the beginning, see:

cc @AntonioConsilvio

pattacini commented 8 months ago

Can I open a PR to fix that?

Sure!

Would you be willing to fix the following robots as well?

This came out from a search: https://github.com/search?q=repo%3Arobotology%2Frobots-configuration+eyes_verg&type=code&p=1.

The PR should be against master as it's a fix.

xEnVrE commented 8 months ago

Would you be willing to fix the following robots as well?

Done!

pattacini commented 8 months ago

Thank you @xEnVrE!