robotology / robots-configuration

Contains robots configuration files
BSD 3-Clause "New" or "Revised" License
14 stars 69 forks source link

wrist mk2.1 files for activating IMU on the setup #619

Closed simeonedussoni closed 2 months ago

simeonedussoni commented 8 months ago

I added some files to enable IMU reading on an MTB to be placed on the hand-mockup for testing the movement capabilities of the wrist.

The modifications are to be tested on the setup in the next days so for the moment I put a draft tag

PLUS I implemented the renaming of the body parts in more logical way e.g. renaming the files for the hand with a coherent name.

pattacini commented 8 months ago

Hi @simeonedussoni

There are many modifications done to ergoCubSN001 that are not mentioned and, at first sight, do not look pertinent to a PR for a setup.

Are they intended?

pattacini commented 7 months ago

Gentle reminder for @simeonedussoni

simeonedussoni commented 7 months ago

Hi @simeonedussoni

There are many modifications done to ergoCubSN001 that are not mentioned and, at first sight, do not look pertinent to a PR for a setup.

Are they intended?

yes, they are intended to clean up the naming as suggested elsewhere. I'd add the description in the PR for this.

simeonedussoni commented 7 months ago

commit fixes used parameters, the setup is working and the PR can go on

simeonedussoni commented 7 months ago

@pattacini I'll do it!

pattacini commented 7 months ago

Thanks heaps!

simeonedussoni commented 7 months ago

I also implemented and tested a slilghtly modifed version of the configuration files to read another MTB4 used for the reference frame. gonna produce one commit with the ergocubSN0002 implementation and one commit with the setup dual-MTB configuration. in case future users will need only one they can simply comment out relevant parameters

pattacini commented 7 months ago

Jut put this PR in draft so that once you're done with the last commit, @simeonedussoni, you can signal that by putting the PR back in ready for review.

pattacini commented 7 months ago

Hi @simeonedussoni

There are conflicts deserving your attention. Please, addressed them and once solved and pushed remember to put the PR in ready for review.

pattacini commented 7 months ago

Gentle reminder for @simeonedussoni

pattacini commented 6 months ago

/remind Wednesday @simeonedussoni please finalize the PR

octo-reminder[bot] commented 6 months ago

Reminder Wednesday, April 3, 2024 10:00 AM (GMT+02:00)

@simeonedussoni please finalize the PR

octo-reminder[bot] commented 6 months ago

🔔 @pattacini

@simeonedussoni please finalize the PR

simeonedussoni commented 6 months ago

@pattacini I tested the PR on ergocub and it was working but I didn't know whethet the robot was aligned with devel branch. I'd go to have a clean test when ergocub is back rather than flagging as ready a PR I don't trust 100%. Let me know your point of view.

pattacini commented 6 months ago

Ok with me!

pattacini commented 5 months ago

/remind May 13, @simeonedussoni please finalize the PR.

octo-reminder[bot] commented 5 months ago

Reminder Monday, May 13, 2024 10:00 AM (GMT+02:00)

, @simeonedussoni please finalize the PR.

octo-reminder[bot] commented 5 months ago

🔔 @pattacini

, @simeonedussoni please finalize the PR.

pattacini commented 2 months ago

Hi @simeonedussoni

This PR is long overdue. There are conflicts to fix and in the meanwhile many things have happened as the new way of handling robots-configuration on ergoCub systems.

For these reasons, instead of leaving the PR stale, I would rather consider closing it unmerged, leaving you the choice to plan for a start-over.

simeonedussoni commented 2 months ago

that's fine for me. I'd restart this activity once finished with other higher-prioriy ones. I still have to understand the new policy of ergocub sw maintenance and how this affects the workflow.

pattacini commented 2 months ago

Ok then!

I still have to understand the new policy of ergocub sw maintenance and how this affects the workflow.

I'll be mostly off this month. Just cc'ing others who may be available in presence and are already in the loop of this change: @Nicogene @valegagge @marcoaccame @AntonioConsilvio @traversaro @S-Dafarra