Closed simeonedussoni closed 2 months ago
Hi @simeonedussoni
There are many modifications done to ergoCubSN001 that are not mentioned and, at first sight, do not look pertinent to a PR for a setup.
Are they intended?
Gentle reminder for @simeonedussoni
Hi @simeonedussoni
There are many modifications done to ergoCubSN001 that are not mentioned and, at first sight, do not look pertinent to a PR for a setup.
Are they intended?
yes, they are intended to clean up the naming as suggested elsewhere. I'd add the description in the PR for this.
commit fixes used parameters, the setup is working and the PR can go on
@pattacini I'll do it!
Thanks heaps!
I also implemented and tested a slilghtly modifed version of the configuration files to read another MTB4 used for the reference frame. gonna produce one commit with the ergocubSN0002 implementation and one commit with the setup dual-MTB configuration. in case future users will need only one they can simply comment out relevant parameters
Jut put this PR in draft so that once you're done with the last commit, @simeonedussoni, you can signal that by putting the PR back in ready for review.
Hi @simeonedussoni
There are conflicts deserving your attention. Please, addressed them and once solved and pushed remember to put the PR in ready for review.
Gentle reminder for @simeonedussoni
/remind Wednesday @simeonedussoni please finalize the PR
⏰ Reminder Wednesday, April 3, 2024 10:00 AM (GMT+02:00)
@simeonedussoni please finalize the PR
🔔 @pattacini
@simeonedussoni please finalize the PR
@pattacini I tested the PR on ergocub and it was working but I didn't know whethet the robot was aligned with devel
branch. I'd go to have a clean test when ergocub is back rather than flagging as ready a PR I don't trust 100%. Let me know your point of view.
Ok with me!
/remind May 13, @simeonedussoni please finalize the PR.
⏰ Reminder Monday, May 13, 2024 10:00 AM (GMT+02:00)
, @simeonedussoni please finalize the PR.
🔔 @pattacini
, @simeonedussoni please finalize the PR.
Hi @simeonedussoni
This PR is long overdue. There are conflicts to fix and in the meanwhile many things have happened as the new way of handling robots-configuration on ergoCub systems.
For these reasons, instead of leaving the PR stale, I would rather consider closing it unmerged, leaving you the choice to plan for a start-over.
that's fine for me. I'd restart this activity once finished with other higher-prioriy ones. I still have to understand the new policy of ergocub sw maintenance and how this affects the workflow.
Ok then!
I still have to understand the new policy of ergocub sw maintenance and how this affects the workflow.
I'll be mostly off this month. Just cc'ing others who may be available in presence and are already in the loop of this change: @Nicogene @valegagge @marcoaccame @AntonioConsilvio @traversaro @S-Dafarra
I added some files to enable IMU reading on an MTB to be placed on the hand-mockup for testing the movement capabilities of the wrist.
The modifications are to be tested on the setup in the next days so for the moment I put a draft tag
PLUS I implemented the renaming of the body parts in more logical way e.g. renaming the files for the hand with a coherent name.