robotology / robots-configuration

Contains robots configuration files
BSD 3-Clause "New" or "Revised" License
14 stars 69 forks source link

Cleanup yarprobotinterface conf files for ergoCub #645

Closed traversaro closed 4 months ago

traversaro commented 4 months ago

Fix https://github.com/robotology/robots-configuration/issues/641 .

The changes in the PR are the one described in https://github.com/robotology/robots-configuration/issues/641#issue-2239652775 . I actually used the same ergocub.xml for all ergoCub robots, with the following differences:

To avoid regressions, this PR does not remove any existing ergocub_***.xml files. Once the new ergocub.xml are tested and working, we can remove the ergocub_***.xml files in a follow up PR.

pattacini commented 4 months ago

In ergoCubSN001, there was also a line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.

Ok! Let's get rid of it and monitor the situation.

To avoid regressions, this PR does not remove any existing ergocub***.xml files. Once the new ergocub.xml are tested and working, we can remove the ergocub***.xml files in a follow up PR.

Agree 👍🏻 I'll open a follow-up issue for the cleanup.

traversaro commented 4 months ago

In ergoCubSN001, there was also a <xi:include href="wrappers/motorControl/head-mc-slow_wrapper.xml" /> line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.

fyi @S-Dafarra @GiulioRomualdi as it was added in https://github.com/robotology/robots-configuration/pull/616

pattacini commented 4 months ago

In ergoCubSN001, there was also a <xi:include href="wrappers/motorControl/head-mc-slow_wrapper.xml" /> line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.

fyi @S-Dafarra @GiulioRomualdi as it was added in #616

In case it is actually needed, we're required to deal with ergoCubSN002 as well via a new PR.

S-Dafarra commented 4 months ago

In ergoCubSN001, there was also a <xi:include href="wrappers/motorControl/head-mc-slow_wrapper.xml" /> line that is not in other robots. Is this actually used? For the time being, I did not included that in the PR.

fyi @S-Dafarra @GiulioRomualdi as it was added in #616

It is needed to avoid high bandwidth usage when performing remote teleoperation. We have a module on the operator side connecting to that control board only, so we added another wrapper running at low frequency

pattacini commented 4 months ago

It is needed to avoid high bandwidth usage when performing remote teleoperation. We have a module on the operator side connecting to that control board only, so we added another wrapper running at low frequency

Ok then. I'll reinstate #616 and duplicate it for ergoCubSN002.

pattacini commented 4 months ago

Ok then. I'll reinstate #616 and duplicate it for ergoCubSN002.

Done via #647.