robotology / robots-configuration

Contains robots configuration files
BSD 3-Clause "New" or "Revised" License
14 stars 69 forks source link

ergoCubSN001 002- update network file #652

Closed davidetome closed 4 months ago

davidetome commented 5 months ago

This PR updates the network file of the robots ergoCub SN001 and ergoCubSN002

cc @valegagge

davidetome commented 5 months ago

Hi @davidetome

Could you provide some insights underlying this big change? Also, would it be worth covering the other ergoCub as well?

Possibly, there's one typo requiring attention. Didn't spot others but, please, check it.

Ciao @pattacini !!!

I noticed that the network file was not aligned to the real architecture ,

I just fixed some errors w/ the last commit today and checked again w/ the schematic.

Also SN002 is not correct (probably copied when the folder was created)

cc @valegagge @AntonioConsilvio

pattacini commented 5 months ago

I noticed that the network file was not aligned to the real architecture ,

I just fixed some errors and checked again w/ the schematic.

Superb! Thanks heaps!

Also SN002 is not correct (probably copied when the folder was created)

Then, it'd be great if we could fix it up as well.

@AntonioConsilvio, you may consider checking these things out for SN000, which is by us these days.

davidetome commented 5 months ago

@pattacini @AntonioConsilvio , as suggested by @valegagge , I also fixed SN002 with the last commit 👍🏼

pattacini commented 5 months ago

Thanks @davidetome 🚀

AntonioConsilvio commented 5 months ago

Hi! Well done @davidetome.

I'd just like to add that some boards are actually not connected to each other.

For example, the 10.0.1.2 board, has no boards before it, because it's connected to the ETH switch (Gigablox) so it might make sense to edit line 66 in exactly the same way as 10.0.1.5 (i.e. without the prev parameter - line 266)? Similarly, 10.0.1.21 has no boards after it, so it might make sense to remove the next parameter (line 56)?

Other boards might have this little problem, in the architecture the ETH switch is represented like this:

image

cc @pattacini

davidetome commented 5 months ago

Hi! Well done @davidetome.

I'd just like to add that some boards are actually not connected to each other.

For example, the 10.0.1.2 board, has no boards before it, because it's connected to the ETH switch (Gigablox) so it might make sense to edit line 66 in exactly the same way as 10.0.1.5 (i.e. without the prev parameter - line 266)? Similarly, 10.0.1.21 has no boards after it, so it might make sense to remove the next parameter (line 56)?

Other boards might have this little problem, in the architecture the ETH switch is represented like this:

image

cc @pattacini

ciao @AntonioConsilvio , it doesn't matter...the previous and next tag are only for info when reading the file. you can also not declare them and the script runs the same

cc @pattacini

davidetome commented 5 months ago

@AntonioConsilvio , just to make you happy I just fixed them with the last commit 😄 👍🏼

davidetome commented 4 months ago

as suggested by @valegagge I added the network files for 2foc update for ergoCubSN001 and ergoCubSN002 used to change their FW for demos (AMI req)