robotology / robots-configuration

Contains robots configuration files
BSD 3-Clause "New" or "Revised" License
14 stars 69 forks source link

Enable tags not working for ros2 #663

Closed SimoneMic closed 2 months ago

SimoneMic commented 2 months ago

Hello, I have tried the command for launching the YRI with ros2 enabled, as listed in this issue #641

However the format is not recognised:

yarprobotinterface --config ergocub.xml --enable_tags (enable_ros2) 
-bash: syntax error near unexpected token `('

I have also tried removing the brackets, the robot starts, but Ros is not enabled. Also by removing the --config part. Same result.

traversaro commented 2 months ago

Can you try:

yarprobotinterface --config ergocub.xml --enable_tags "(enable_ros2)"

Not sure why I did not experienced this problem, perhaps I tested on Windows.

pattacini commented 2 months ago

Any feedback @SimoneMic?

SimoneMic commented 2 months ago

I haven't used the robot today, when I'll have my slot I will test it

pattacini commented 2 months ago

Thanks!

GiulioRomualdi commented 2 months ago
yarprobotinterface --config ergocub.xml --disable_tags \(disable_right_arm\) 

works

pattacini commented 2 months ago

Uhm, the format with the escape char \ doesn't seem very clear in the first place, unless it's reported in the documentation. If not, it should be pointed out in YARP, somehow cc @randaz81.

Out of curiosity, does it mean that "(disable_right_arm)" doesn't work?

SimoneMic commented 2 months ago

With the "()" it works, at least with enable_ros2. The documentation should be changed, I think

randaz81 commented 2 months ago

I never heard about the use of '\', I think it works by chance (undocumented and to be avoided.) Instead if i remeber correctly you should always use " to encapsulate a ( ) block, independently if it contains multiple elements or just one, like in your case.

pattacini commented 2 months ago

Yeah, indeed, the standard ought to be "(...)". I remember now that I used it in the past for the find-superquadric module:

I think we can close it. Feel free to open it up again if you deem it necessary.

traversaro commented 2 months ago

The documentation should be changed, I think

Which documentation?

SimoneMic commented 1 month ago

https://github.com/robotology/robots-configuration/issues/641 which has already been updated