search

robotology / robots-configuration

Contains robots configuration files
BSD 3-Clause "New" or "Revised" License
14 stars 69 forks source link

Fixed typo in local-workflow-tech #667

Closed S-Dafarra closed 2 months ago

S-Dafarra commented 2 months ago

The remote to change is not origin but icub-tech

pattacini commented 2 months ago

Actually, the convention for remotes on a fork usually is:

I wasn't aware there was a remote called icub-tech, which would be peculiar to our system and not created at clone time.

S-Dafarra commented 2 months ago

Actually, the convention for remotes on a fork usually is:

  • origin: points to the fork repo on GH.
  • upstream: points to the upstream repo on GH.

I wasn't aware there was a remote called icub-tech, which would be peculiar to our system and not created at clone time.

Actually, the repo gets cloned by the super build using robotology as origin. I thought it would be less error prone specifying a different remote name for the robot workflows only. This also enforces the good practice of not changing origin when adding a new fork to the repo

pattacini commented 2 months ago

Actually, the repo gets cloned by the super build using robotology as origin.

I see, I missed this point. Then, I would explain somewhere in the instructions that icub-tech is the remote pointing to the fork.

pattacini commented 2 months ago

Then, I would explain somewhere in the instructions that icub-tech is the remote pointing to the fork.

It's already introduced here: