search

robotology / simmechanics-to-urdf

Script for converting simmechanics XML files to URDF
34 stars 8 forks source link

catkin build dependency not listed? #29

Closed fjandrad closed 7 years ago

fjandrad commented 7 years ago

Hi it might have been obvious and not required but following instructions step by step I found that I was laking catkin-pkg to run sudo python setup.py install

Should we add this to the dependencies? sudo apt-get install python-catkin-pkg

traversaro commented 7 years ago

You are correct. Catkin used not to be necessary, but some months ago (I guess around February 2017, see https://github.com/robotology/simmechanics-to-urdf/commit/b2d755ef400c1b82bf45dcafcf1fc97f49852ba5) the urdf_parser_py changed the default branch of the repo from master to indigo-devel without any announcement. I now think that the master branch is not maintained (see https://github.com/ros/urdf_parser_py/issues/24) so I guess we should simply require catkin to be installed in the system. Installing catkin should be straightforward also on Windows, as it is available at a pip package (https://pypi.python.org/pypi/catkin_pkg/). Let's keep this issue open until we fix the docs. cc @fiorisi because this may affect used of the tool in Windows.

fiorisiBot commented 7 years ago

I think that we can close this issue. See https://github.com/robotology/simmechanics-to-urdf/commit/6afa4ebf77e7c5c5b054ddcaa765df4a362b0cf1.