robotology / simmechanics-to-urdf

Script for converting simmechanics XML files to URDF
34 stars 8 forks source link

Fix malformed link material element #37

Closed traversaro closed 6 years ago

traversaro commented 6 years ago

The URDF "specification" ( http://wiki.ros.org/urdf ) and its "reference implementation" ( https://github.com/ros/urdfdom ) allow to have a material element without a color child element, but only if the name of the color is specified in the model-wide material database. Otherwise, it is always necessary to specify the color of the material of the link.

Fix https://github.com/robotology/icub-model-generator/issues/36 See https://github.com/robotology/icub-model-generator/issues/36#issuecomment-313065203

This should get rid of the terrible [ERROR] :: parseURDFMaterial : Impossible to parse URDF material, material black not found in model database. warnings when loading an iCub model generated with simmechanics-to-urdf .

traversaro commented 6 years ago

Friendly ping @diegoferigo @fiorisi

traversaro commented 6 years ago

@diegoferigo @fiorisi Can we manually ask for a new generation of the icub-models repo after this PR?