search

robotology / simmechanics-to-urdf

Script for converting simmechanics XML files to URDF
34 stars 8 forks source link

Export ft sensor frames #53

Closed Nicogene closed 1 year ago

Nicogene commented 1 year ago

This PR re-enable the exportation of the ft frames, the name exported is exportedFrameName, if not defined the first fallback is sensorName, if even sensorName is not defined it is exported with jointName name.

If exportFrameInURDF is set to Yes linkName and frameName are mandatory.

It fixes #52

traversaro commented 1 year ago

@Nicogene is this ready for review? For the future, it would be great to split the whitespaces changes and the actual logic changes in two different commits, to simplify review.

traversaro commented 1 year ago

Can you update the CHANGELOG file? Thanks!

Nicogene commented 1 year ago

@Nicogene is this ready for review? For the future, it would be great to split the whitespaces changes and the actual logic changes in two different commits, to simplify review.

Yes it is ready 👍🏻

You are right, I did git commit -am and I didn't noticed that vs code saving the file removed also the trailing whitespace