search

robotology / superquadric-model

Framework for modeling and visualizing objects through superquadrics
GNU General Public License v2.0
6 stars 4 forks source link

Don't use "using namespace" within header files #26

Closed pattacini closed 7 years ago

pattacini commented 7 years ago

Please, avoid relying on the using namespace within header files 😉 I know I might be a bit fussy, but it's better to put forward this best practice.

giuliavezzani commented 7 years ago

Ah ok, I saw this use in iolStateMachineHandler of iol repository and I thought it was a good practise. I'll remove them immediately!

pattacini commented 7 years ago

There's a very dangerous impact for library headers; nonetheless, it's better to be consistent also with modules, where the impact is quite limited.

giuliavezzani commented 7 years ago

Moved the using::namespace from the headers to src 1b0640e.