search

robotology / unicycle-footstep-planner

Repository for the Unicycle-based FootStep Planner.
BSD 3-Clause "New" or "Revised" License
20 stars 11 forks source link

Merge devel branch in master #18

Closed S-Dafarra closed 5 years ago

S-Dafarra commented 5 years ago

cc @GiulioRomualdi, @traversaro, @aikolina

This merge will deprecate the previous UnicyclePlanner interface. Please check if this breaks your pipeline. Refer to me to migrate from one interface to the other.

traversaro commented 5 years ago

Even if in the master you are not exporting the version number in CMake configuration file, I suggest to make a release/tag of the latest commit with the old branch, so that if anyone has any problem, it would be trivial to switch to the "old version". Furthermore, is the old interface "deprecated" (i.e. it is still there with the same API, its use is just discouraged because it will be eventually changed/removed) or it is actually have been changed/removed (I understood that the change was breaking)? For research grade software I see no problem in breaking changes, but if that it is the case the PR should mention it, and not say that the old interface is "deprecated".

S-Dafarra commented 5 years ago

Furthermore, is the old interface "deprecated" (i.e. it is still there with the same API, its use is just discouraged because it will be eventually changed/removed) or it is actually have been changed/removed (I understood that the change was breaking)?

It should not be breaking. Old interfaces should just throw warning, and this is what I want to make sure of. The compatibility will be broken only with the dcmTrajectoryGenerator branch which will remain stale to guarantee that old versions of walking-controllers will keep working.

traversaro commented 5 years ago

It should not be breaking. Old interfaces should just throw warning, and this is what I want to make sure of.

Great.

traversaro commented 5 years ago

Thanks to @aikolina , tests with internal software went fine.

S-Dafarra commented 5 years ago

Thanks a lot!

S-Dafarra commented 5 years ago

I suggest to make a release/tag of the latest commit with the old branch, so that if anyone has any problem, it would be trivial to switch to the "old version".

Tag available here