search

robotology / walking-teleoperation

Software related to walking and teleoperation.
BSD 3-Clause "New" or "Revised" License
30 stars 14 forks source link

Fix Haptic glove transmission - HapticGloveModule (Recovered PR) #143

Closed EhsanRanjbari closed 3 months ago

EhsanRanjbari commented 4 months ago

See https://github.com/robotology/walking-teleoperation/pull/139

S-Dafarra commented 3 months ago

Hi @EhsanRanjbari, I took a look at the PR and looks good! Well done!

We can wait for the final edits of https://github.com/robotology/wearables/pull/204, then, after a final test on the robot, I think we can merge this!

EhsanRanjbari commented 3 months ago

As mentioned in https://github.com/robotology/wearables/pull/204#issuecomment-2182696307, the tests were successful.

EhsanRanjbari commented 3 months ago

@S-Dafarra , should we change the version also here?

https://github.com/robotology/walking-teleoperation/blob/3d543c9c890cbea68a7229fe7bc95b49fdbdcea4/CMakeLists.txt#L7-L8

1.3.5?

S-Dafarra commented 3 months ago

Yes, that makes sense

GiulioRomualdi commented 3 months ago

If @mebbaid and @S-Dafarra are ok, you can merge the PR

S-Dafarra commented 3 months ago

Hi @EhsanRanjbari, could you specify the desired Wearables version in https://github.com/robotology/walking-teleoperation/blob/afed05ed278efc3d49e98137b52cec3cf3d5619f/cmake/WalkingTeleoperationFindDependencies.cmake#L156 and https://github.com/robotology/walking-teleoperation/blob/afed05ed278efc3d49e98137b52cec3cf3d5619f/cmake/WalkingTeleoperationFindDependencies.cmake#L159

S-Dafarra commented 3 months ago

Thanks @EhsanRanjbari, I will proceed in merging this!