robotology / wb-toolbox

Simulink toolbox to rapidly prototype robot controllers
https://robotology.github.io/wb-toolbox/
GNU Lesser General Public License v2.1
23 stars 17 forks source link

Block [15-DoFs WBI to YARP] indeces are out of range #33

Closed hu-yue closed 8 years ago

hu-yue commented 8 years ago

Description:

I haven't used the toolbox since ages, I wanted to use it again today, but I spotted a problem in the 15-DoFs WBI to YARP block. I am assuming that this block is supposed to be used with a robot with reduced number of DOF (iCubHeidelberg), and that therefore the indeces of the joints should go from 1 to 15. Instead in the legs the indeces are 12:17 and 18:23, which are of course out of range if used with iCubHeidelberg. As a side note, also in the block description you still say 23 instead of 15.


Further Information:

francesco-romano commented 8 years ago

Hi @hu-yue . These kind of blocks were directly ported from the old toolbox, so I did not modify them when I developed the WB-Toolbox. I'd always wanted to make this kind of block generic, but at the current state I've never managed to. I'll take a look at the current block so to fix it.

francesco-romano commented 8 years ago

@hu-yue can you check if it is all right now, and reopen the issue otherwise?

hu-yue commented 8 years ago

@francesco-romano it works fine, thanks =)