search

robotology / wearables

Code moved to https://github.com/robotology/human-dynamics-estimation
https://github.com/robotology/human-dynamics-estimation
BSD 3-Clause "New" or "Revised" License
19 stars 11 forks source link

Do not overwrite default linker flags so that LDFLAGS environment variable is considered #110

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

If one wants to specify additional linked flags, those should be appended to CMAKE_SHARED_LINKER_FLAGS, not overwrite it as this would lead to the LDFLAGS environment variable to be ignored, leading to linking errors in some environments (for example conda).

For more details see:

It would be convenient to tag a released after this fix is integrated to fix the conda binary generation at the robotology-superbuild level (see https://github.com/robotology/robotology-superbuild/issues/681). Let me know if you want to do that or you like me to do it.

Fix https://github.com/robotology/robotology-superbuild/issues/681 .

traversaro commented 3 years ago

FYI @Yeshasvitvs @lrapetti

lrapetti commented 3 years ago

It would be convenient to tag a released after this fix is integrated to fix the conda binary generation at the robotology-superbuild level (see robotology/robotology-superbuild#681). Let me know if you want to do that or you like me to do it.

@traversaro Done https://github.com/robotology/wearables/releases/tag/v1.2.1