robotology / wearables

Code moved to https://github.com/robotology/human-dynamics-estimation
https://github.com/robotology/human-dynamics-estimation
BSD 3-Clause "New" or "Revised" License
19 stars 11 forks source link

Disable default enabling of XsensSuit device #141

Closed RiccardoGrieco closed 2 years ago

RiccardoGrieco commented 2 years ago

This PR to disable the building of the XsensSuit device by default on Windows, since one may want to use the wearable library without it.

I also changed the name of the XSENS_MVN_USE_SDK option to Enable_XsensSuit to be in line with the other devices.

One thing that can be done is enabling the option by default only if XsensXME is found.

traversaro commented 2 years ago

Thanks @lrapetti, I was going to write exactly the same!

RiccardoGrieco commented 2 years ago

I fixed an error in the use of lower cases for ENABLE_XsensSuit.

Thanks @lrapetti @traversaro for the review. I will merge the changes as soon as the CI end.

I also opened the draft PR https://github.com/robotology/robotology-superbuild/pull/1027, which is to be merged after the new release of wearables.