search

robotology / wearables

Data collection framework for wearable sensors
BSD 3-Clause "New" or "Revised" License
19 stars 11 forks source link

Migrate from YARP_telemetry to robometry #155

Closed Nicogene closed 2 years ago

Nicogene commented 2 years ago

See https://github.com/robotology/robometry/pull/173

Please review code.

Nicogene commented 2 years ago

I am not sure if the changes in ci.yml works

lrapetti commented 2 years ago

Btw, it might be worth mentioning this modification in the CHANGELOG.md

Nicogene commented 2 years ago

Overall looks good, but the CI seems to be failing on WIndows

I think that the CI will be broken until the new robometry packets will be released am I right @traversaro ?

traversaro commented 2 years ago

Overall looks good, but the CI seems to be failing on WIndows

I think that the CI will be broken until the new robometry packets will be released am I right @traversaro ?

Yes

Nicogene commented 2 years ago

Here https://github.com/robotology/wearables/pull/155/commits/9caf780e949891b7890a15ab387f38ff7e4a7f46 I removed the installation of robometry in the CI for windows since the conda packages.

This means that IWearLogger will be untested under windows until we have the packets What do you think about @lrapetti @traversaro ?

traversaro commented 2 years ago

Here 9caf780 I removed the installation of robometry in the CI for windows since the conda packets.

This means that IWearLogger will be untested under windows until we have the packets What do you think about @lrapetti @traversaro ?

I think it is a good idea.

lrapetti commented 2 years ago

This means that IWearLogger will be untested under windows until we have the packets What do you think about @lrapetti @traversaro ?

That's ok. We could open an issue after merging this PR in order to remember to add it back

@Nicogene if the PR is ready I would proceed merging.

Nicogene commented 2 years ago

This means that IWearLogger will be untested under windows until we have the packets What do you think about @lrapetti @traversaro ?

That's ok. We could open an issue after merging this PR in order to remember to add it back

@Nicogene if the PR is ready I would proceed merging.

I opened the issue, I merge it! https://github.com/robotology/wearables/issues/156