search

robotology / whole-body-estimators

YARP devices that implement estimators for humanoid robots.
26 stars 12 forks source link

Fix deprecation with iDynTree 3 #116

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

In https://github.com/robotology/idyntree/pull/770 the getSensorIndex variant that takes std::ptrdiff_t was deprecated, and it has been removed in the upcoming iDynTree 4 (https://github.com/robotology/idyntree/pull/884). This PR fixes the deprecation warning in iDynTree 3 and the compilation with iDynTree 4.

I also bumped the version of iDynTree used in CI that it was quite old, and prevented the CI to compile correctly this PR.

traversaro commented 3 years ago

I took the liberty of also bumping a release after this PR, as it would be good to have this out before iDynTree 4 gets released.

traversaro commented 3 years ago

Yes, being a bug fix I was thinking of merging in master and then forward merge to devel.

traversaro commented 3 years ago

@prashanthr05 @HosameldinMohamed let me know if you prefer to handle the merge+release or if you prefer me to do it.

HosameldinMohamed commented 3 years ago

@prashanthr05 @HosameldinMohamed let me know if you prefer to handle the merge+release or if you prefer me to do it.

I can do it.

traversaro commented 3 years ago

Thanks @HosameldinMohamed ! Let me know if you need help then forward merging this to devel (the basic idea is similar to https://github.com/robotology/yarp/blob/master/.github/CONTRIBUTING.md#stable-branches-yarp-3x, but in the case of this repo the stable branch is master (in YARP is the yarp-3.x branch) and the development branch is devel (in YARP is master).

HosameldinMohamed commented 3 years ago

New release v0.5.1

traversaro commented 3 years ago

New release v0.5.1

Thanks! I launched a new robotology-superbuild job to check if the compilation is indeed back to normal: https://github.com/robotology/robotology-superbuild/actions/runs/1022800284 .