robotology / whole-body-estimators

YARP devices that implement estimators for humanoid robots.
24 stars 12 forks source link

Introduce MAS Read in whole body estimator #153

Closed CarlottaSartore closed 1 year ago

CarlottaSartore commented 2 years ago

C.C. @traversaro

isorrentino commented 2 years ago

Can we merge this PR? Before merging I think it is necessary to rebase this branch on master. Maybe also the line in the Changelog is still missing.

The code has been tested a lot in the last months and everything worked fine. If we merge it, when we update the robotology-superbuild to a new distro, we no longer need to manually move whole-body-estimator to this branch.

cc @prashanthr05 @traversaro @CarlottaSartore

isorrentino commented 2 years ago

CHANGELOG updated!

CarlottaSartore commented 2 years ago

Thanks @isorrentino, from my point of view this PR can be merged, we tested also in Rimini and everything went fine !

isorrentino commented 2 years ago

cc @HosameldinMohamed

traversaro commented 1 year ago

Sorry @HosameldinMohamed, did you had a chance of checking this PR?

HosameldinMohamed commented 1 year ago

Sorry @HosameldinMohamed, did you had a chance of checking this PR?

Not yet, sorry for the delay. Doing it now..

traversaro commented 1 year ago

Thanks @HosameldinMohamed !