search

robotology / whole-body-estimators

YARP devices that implement estimators for humanoid robots.
26 stars 12 forks source link

Migrate wholebodydynamics and related devices and libraries in whole-body-estimators #16

Closed traversaro closed 4 years ago

traversaro commented 4 years ago

I originally planned to migrate also the history of the code, but as I was not expert in the procedure, I realized that the effort was probably not worth the gain.

If anyone is interested, will be found in https://github.com/robotology-legacy/codyco-modules (at the moment the link is not active as the repo still needs to be migrated).

There are several parts of the code that would need to be cleaned up/removed deprecations/etc/etc, but I preferred to reduce at the minimum the modifications to the code in codyco-modules. Once the code has been merged, we can do the all the cleanup, in a clear and trackable way.

cc @fjandrad @HosameldinMohamed unfortunatly any open PR needs to be re-created against the new repo, homever it should not be difficult as the files location is similar.

prashanthr05 commented 4 years ago

It is crucial to test the migrated wholebodydynamics devices on the robot (iCubGenova04, active users of the device) with Yoga++ controller and walking controller.

This was done on 09 March 2020.

fjandrad commented 4 years ago

Shall we press the Merge button @prashanthr05 @traversaro

traversaro commented 4 years ago

Yes, I guess that that @prashanthr05 can do that.

prashanthr05 commented 4 years ago

https://github.com/robotology/whole-body-estimators/pull/16/files#diff-0e39020ad0dd65979c2316050995dfa1 is a kate-swp files that needs to be removed.

This is still pending.

prashanthr05 commented 4 years ago

Let me delete that and push a commit. Then I will merge.

prashanthr05 commented 4 years ago

@traversaro @fjandrad Merged into devel, Thank you!

prashanthr05 commented 4 years ago

@traversaro shall I go ahead and remove the add-wbd branch?

traversaro commented 4 years ago

@traversaro shall I go ahead and remove the add-wbd branch?

Yes thanks!

fjandrad commented 4 years ago

So now, we wait for the inclusion of whole-body-estimators into robotology-superbuild should I open an issue for that? @traversaro

traversaro commented 4 years ago

So now, we wait for the inclusion of whole-body-estimators into robotology-superbuild should I open an issue for that? @traversaro

Yes, please open an issue for that, I plan to work on this on the next days.