robotology / whole-body-estimators

YARP devices that implement estimators for humanoid robots.
24 stars 12 forks source link

fix attaching both IMU and FTs as MAS network wrappers #167

Closed HosameldinMohamed closed 1 year ago

HosameldinMohamed commented 1 year ago

This is a part of the investigation we are doing with @mebbaid using ergoCubGazeboV1 https://github.com/icub-tech-iit/ergocub-software/issues/35

We couldn't attach both the IMU and the FTs as MAS.

With the previous logic before this PR, the software doesn't distinguish between them. As it seems both devices types implement all the MAS interfaces, including the interfaces ISixAxisForceTorqueSensors and IThreeAxisLinearAccelerometers.

traversaro commented 1 year ago

For the CI you can see https://github.com/robotology/idyntree-yarp-tools/pull/42 .

HosameldinMohamed commented 1 year ago

For the CI you can see robotology/idyntree-yarp-tools#42 .

Thanks for the info, I'll do it in a new PR to keep it organized!

HosameldinMohamed commented 1 year ago

From recent tests with real robots (ergoCub, iCubGenova09), the issue solved by this PR happens only when attaching network wrappers multipleAnalogSensorServer because they implement all the MAS interfaces.

While attaching directly the FT devices embObjMultipleFTsensors and the IMU devices embObjIMU goes through with no errors because these devices implement only the corresponding interfaces.

CC @GiulioRomualdi